Format code for prototype/deploy_code_to_brain_old/code_for_testing #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PlatinumWolf128
added a commit
that referenced
this pull request
Jan 8, 2025
- The maximum range of the frontBackVelocity being passed into robotDrive is [-1, 1], even though the velocity range for robotDrive is [-100, 100], so now when frontBackVelocity is passed into the robotDrive function it is multiplied by 100 - We realized that controllerFrontBackPosition was equal to the position of the joystick on axis #3, and that controllerLeftRightPosition was assigned axis #4. - Weirdly, the bot was still able to drive with acceleration disabled, but we think the axis mix-up made it so the bot couldn't turn while acceleration was enabled. - Something in the arcade drive formula is causing the controls to be inverted (e.g. Pushing the joystick forwards made the bot drive backwards). We weren't able to find the root of the issue but know that making controllerFrontBackPosition and controllerLeftRightPosition negative solves the issue (e.g. Calling robotDrive like robotDrive(-controllerFrontBackPosition, -controllerLeftRightPosition)). - Further testing is needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formatted code using the style defined in the .clang-format file.