Merge pull request #641 from ergebnis/feature/name

Enhancement: Show name and author of plugin
ergebnis · Dec 29, 2020 · 9df7fce · 9df7fce
2 parents ef1f145 + 36d9520
commit 9df7fce
Show file tree

Hide file tree

Showing 4 changed files with 50 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -12,6 +12,10 @@ For a full diff see [`2.12.0...main`][2.12.0...main].
 
 For a full diff see [`2.11.0...2.12.0`][2.11.0...2.12.0].
 
+### Added
+
+* Started showing plugin and author name when running `composer normalize` ([#641]), by [@localheinz]
+
 ### Fixed
 
 * Required `composer/composer:2.0.8` for `composer-normalize.phar` ([#596]), by [@localheinz]
@@ -620,6 +624,7 @@ For a full diff see [`81bc3a8...0.1.0`][81bc3a8...0.1.0].
 [#597]: /~https://github.com/ergebnis/composer-normalize/pull/597
 [#608]: /~https://github.com/ergebnis/composer-normalize/pull/608
 [#615]: /~https://github.com/ergebnis/composer-normalize/pull/615
+[#641]: /~https://github.com/ergebnis/composer-normalize/pull/641
 
 [@core23]: /~https://github.com/core23
 [@dependabot]: /~https://github.com/dependabot

diff --git a/src/Application.php b/src/Application.php
@@ -20,12 +20,46 @@
  */
 final class Application extends Console\Application
 {
+    /**
+     * @see /~https://github.com/box-project/box/blob/master/doc/configuration.md#pretty-git-tag-placeholder-git
+     *
+     * @var string
+     */
+    private $version = '@git@';
+
     public function getLongVersion(): string
     {
+        $attribution = 'by <info>Andreas Möller</info> and contributors';
+
+        $version = $this->getVersion();
+
+        if ('' === $version) {
+            return \sprintf(
+                '<info>%s</info> %s',
+                $this->getName(),
+                $attribution
+            );
+        }
+
         return \sprintf(
-            '%s <info>%s</info> with ergebnis/composer-normalize <info>@git@</info>',
+            '<info>%s</info> %s %s',
             $this->getName(),
-            $this->getVersion()
+            $version,
+            $attribution
         );
     }
+
+    public function getName(): string
+    {
+        return 'ergebnis/composer-normalize';
+    }
+
+    public function getVersion(): string
+    {
+        if ('@' . 'git@' === $this->version) {
+            return '';
+        }
+
+        return $this->version;
+    }
 }
diff --git a/src/Command/NormalizeCommand.php b/src/Command/NormalizeCommand.php
@@ -104,6 +104,14 @@ protected function execute(Console\Input\InputInterface $input, Console\Output\O
     {
         $io = $this->getIO();
 
+        $io->write([
+            \sprintf(
+                'Running %s.',
+                $this->getApplication()->getLongVersion()
+            ),
+            '',
+        ]);
+
         $indent = null;
 
         try {

diff --git a/test/Unit/ApplicationTest.php b/test/Unit/ApplicationTest.php
@@ -25,14 +25,9 @@ final class ApplicationTest extends Framework\TestCase
 {
     public function testGetLongVersionReturnsVersion(): void
     {
-        $composerApplication = new \Composer\Console\Application();
         $application = new Application();
 
-        $expected = \sprintf(
-            '%s <info>%s</info> with ergebnis/composer-normalize <info>@git@</info>',
-            $composerApplication->getName(),
-            $composerApplication->getVersion()
-        );
+        $expected = '<info>ergebnis/composer-normalize</info> by <info>Andreas Möller</info> and contributors';
 
         self::assertSame($expected, $application->getLongVersion());
     }