entgql: fixed edge filter #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giautm
force-pushed
the
giautm/fixed-edge-filter
branch
from
354ff32 to
67875f3
Compare
Co-authored-by: Amr Tamimi <amrnt0@gmail.com>
giautm
force-pushed
the
giautm/fixed-edge-filter
branch
from
67875f3 to
c271c76
Compare
Co-authored-by: Amr Tamimi <amrnt0@gmail.com>
giautm
force-pushed
the
giautm/fixed-edge-filter
branch
from
c271c76 to
a97f9a0
Compare
a8m
reviewed
Jun 27, 2022
| @@ -640,6 +640,118 @@ func (s *todoTestSuite) TestPaginationFiltering() { | |||
| }) | |||
| } | |||
|
|
|||
| func (s *todoTestSuite) TestEdgesFiltering() { | |||
There was a problem hiding this comment.
I think we can move this test case to the NestedPagination/NestedConnection one.
Also, in this test case, you don't really test the Query<E> method, because the edges are resolved/loaded by the fields-collector (using eager-loading).
@amrnt, how do you use this API? Do you call these methods directly?
There was a problem hiding this comment.
OK, I see now. It's called childrenLevel1 and that's why it's not loaded.
I still want to give it a look before merging it.
a8m
approved these changes
Jun 27, 2022
|
Is there any docs for edge filtering? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @amrnt for reporting and provide the test cases, ❤️