Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

entgql: add WithRelaySpec to be able to disable Relay specification #323

Merged
merged 1 commit into from
May 26, 2022

Conversation

tadeokondrak
Copy link
Contributor

The naming is based on this comment:

ErrRelaySpecDisabled = errors.New("entgql: must enable relay specification via the WithRelaySpec option")

entgql/extension.go Outdated Show resolved Hide resolved
entgql/schema.go Outdated Show resolved Hide resolved
entgql/schema_test.go Outdated Show resolved Hide resolved
@tadeokondrak tadeokondrak force-pushed the make-relay-optional branch from c3c6b26 to 07bd652 Compare May 25, 2022 23:59
@giautm giautm changed the title entgql: Make Relay type generation optional entgql: add WithRelaySpec to be able to disable Relay specification May 26, 2022
Copy link
Collaborator

@giautm giautm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @a8m any thought?

Copy link
Member

@a8m a8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@giautm giautm merged commit a4f2d34 into ent:master May 26, 2022
@giautm
Copy link
Collaborator

giautm commented May 26, 2022

Thank @tadeokondrak for your contribution, ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants