bc: entproto: convert field.Int into int64 proto fields #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maorlipchuk
changed the title
To avoid the following exception (see [1]), added int64 as an alternative for supported fields for list method.
[1] entproto: failed generating protos: entproto:
failed parsing ent graph: entproto: list method does not support schema "Billing" id type "int64"
maorlipchuk
changed the title
maorlipchuk
changed the title
maorlipchuk
changed the title
maorlipchuk
changed the title
2 tasks
rotemtam
changed the title
rotemtam
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion in ent/ent#2377:
field.Int(which is the default type for ID fields) in Ent were mapped toint32in Protobuf, even though in Ent they areintin Go structs (which is 64-bit on 64-bit systems) andbigintin MySQL and PostgreSQL.math.Int32could not be sent over the wire even though Ent and the database support them.int64.This is a semi-breaking change. It may require servers to change some code (tests for example) to use the new field types. Old clients can keep working against the newly generated servers due to the way Protobuf encodes
int32andint64scalars. See discussion and example on the issue.