sham of non-trapping for cross-repo testing

endojs · Jan 15, 2025 · e3327b8 · e3327b8
1 parent bf416a2
commit e3327b8
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 3 deletions.
diff --git a/packages/marshal/src/encodeToCapData.js b/packages/marshal/src/encodeToCapData.js
@@ -187,6 +187,8 @@ export const makeEncodeToCapData = (encodeOptions = {}) => {
         // work. If we allow sortable symbol keys, this will need to
         // become more interesting.
         const names = ownKeys(passable).sort();
+        // TODO either delete or at-ts-expect-error
+        // @ts-ignore
         return fromEntries(
           names.map(name => [name, encodeToCapDataRecur(passable[name])]),
         );

diff --git a/packages/marshal/src/types.js b/packages/marshal/src/types.js
@@ -22,6 +22,8 @@ export {};
 
 /**
  * @template T
+ * TODO either delete or at-ts-expect-error
+ * // @ts-ignore
  * @typedef {{ '@qclass': T }} EncodingClass
  */
 

diff --git a/packages/pass-style/src/symbol.js b/packages/pass-style/src/symbol.js
@@ -11,7 +11,8 @@ const wellKnownSymbolNames = new Map(
       name => typeof name === 'string' && typeof Symbol[name] === 'symbol',
     )
     .filter(name => {
-      // @ts-expect-error It doesn't know name cannot be a symbol
+      // TODO either delete or at-ts-expect-error
+      // @ts-ignore It doesn't know name cannot be a symbol
       !name.startsWith('@@') ||
         Fail`Did not expect Symbol to have a symbol-valued property name starting with "@@" ${q(
           name,

diff --git a/packages/ses/src/error/assert.js b/packages/ses/src/error/assert.js
@@ -293,6 +293,8 @@ export const sanitizeError = error => {
   } = descs;
 
   const restNames = ownKeys(restDescs);
+  // TODO why did this start warning?
+  // eslint-disable-next-line @endo/restrict-comparison-operands
   if (restNames.length >= 1) {
     for (const name of restNames) {
       delete error[name];
@@ -305,7 +307,8 @@ export const sanitizeError = error => {
     );
   }
   for (const name of ownKeys(error)) {
-    // @ts-expect-error TS still confused by symbols as property names
+    // TODO either delete or at-ts-expect-error
+    // @ts-ignore TS still confused by symbols as property names
     const desc = descs[name];
     if (desc && objectHasOwnProperty(desc, 'get')) {
       defineProperty(error, name, {

diff --git a/packages/ses/src/make-hardener.js b/packages/ses/src/make-hardener.js
@@ -238,7 +238,9 @@ export const makeHardener = () => {
                     // NOTE: Calls getter during harden, which seems dangerous.
                     // But we're only calling the problematic getter whose
                     // hazards we think we understand.
-                    // @ts-expect-error TS should know FERAL_STACK_GETTER
+                    //
+                    // TODO either delete or at-ts-expect-error
+                    // @ts-ignore TS should know FERAL_STACK_GETTER
                     // cannot be `undefined` here.
                     // See /~https://github.com/endojs/endo/pull/2232#discussion_r1575179471
                     value: apply(FERAL_STACK_GETTER, obj, []),