add support for datetime,date,time converters #1398
Closed
+81
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
More information is needed. |
|
I think it's a bit tricky as these types could have different formattings. What do you think? Maybe a generic RegexConverter would cover all these. |
|
@aminalaee You're right but I think it would be better if the both are supported because regex maybe hard for some people to use. |
1 task
|
@Mng-dev-ai Thanks for the PR! I don't think this is the right path to follow on Starlette, but I do think you should be able to create custom converters. I'm going to work on the "register custom converters" PR (follow #1437). That being said, I'm going to close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These converters are useful when we want to capture a URL that contains a Date,Date-time or Time.
e.g. /users/created_at/2020-01-01