Add experimental option to use source wasm phase imports #23175
+68
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Mar 3, 2025
Split out from emscripten-core#23175
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Mar 3, 2025
Split out from emscripten-core#23175
sbc100
added a commit
that referenced
this pull request
Mar 3, 2025
sbc100
force-pushed
the
source_phase
branch
2 times, most recently
from
769d26a to
05cc9e0
Compare
sbc100
changed the title
sbc100
changed the title
kripken
reviewed
Mar 3, 2025
Now that node support has been landed we can test this, at least against the latest node canary builds. See nodejs/node#56919 Fixes: emscripten-core#23047
kripken
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that node support has been landed we can test this, at least
against the latest node canary builds.
See nodejs/node#56919
Fixes: #23047