Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add py3.12 support #234

Merged
merged 2 commits into from
May 20, 2024
Merged

build: add py3.12 support #234

merged 2 commits into from
May 20, 2024

Conversation

uniqueg
Copy link
Member

@uniqueg uniqueg commented May 20, 2024

Description

  • Add support for Python 3.12 (end of life: 2028/10)
  • Address issues raised by CI

Fixes #225

Type of change

Please delete options that are not relevant.

  • Build update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation (or documentation does not need to be updated)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have not reduced the existing code coverage

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @uniqueg - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 2 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

foca/models/config.py Show resolved Hide resolved
Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9c48e6a) to head (6542046).

Current head 6542046 differs from pull request most recent head e85d427

Please upload reports for the commit e85d427 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev      #234   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines          975       977    +2     
=========================================
+ Hits           975       977    +2     
Flag Coverage Δ
test_unit 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uniqueg uniqueg merged commit b1100bc into dev May 20, 2024
43 checks passed
@uniqueg uniqueg deleted the py3.12 branch May 20, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build: add support for Python 3.12
1 participant