Move testdata to root #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elezar
reviewed
Oct 21, 2024
source/pci/pci_test.go
Outdated
| @@ -232,7 +232,8 @@ func TestPciSource(t *testing.T) { | |||
| // Run test cases | |||
| for _, tc := range tests { | |||
| t.Run(tc.name, func(t *testing.T) { | |||
| hostpath.SysfsDir = hostpath.HostDir(filepath.Join(packagePath, "testdata", tc.rootfs, "sys")) | |||
| mockSysfsPath := filepath.Join(packagePath, "..", "..", "testdata", "source", "pci", tc.rootfs, "sys") | |||
There was a problem hiding this comment.
Is the package path used for anything else other than the testdata dir? should we just set that directly instead?
There was a problem hiding this comment.
umm you maybe right, packagePath has no other use, so we could even trim the init func at the beginning of the file
Go mod automatically ignores the /testdata directory. This change ensures that the rootfs for source/pci tests are not included in the module definition. Signed-off-by: Evan Lezar <elezar@nvidia.com>
ArangoGutierrez
force-pushed
the
pr/1921
branch
from
d87efc6 to
66555bf
Compare
elezar
force-pushed
the
move-source-pci-testdata
branch
from
4a82a64 to
b6b1335
Compare
|
Thanks @ArangoGutierrez. I squashed your changes onto kubernetes-sigs#1921 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go mod automatically ignores the /testdata directory. This change ensures that the rootfs for source/pci tests are not included in the module definition.