fix: summary report severity count #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vulnerabilities should be sorted by severity kind instead of severity score. This is because the acknowledged kind is computed by us, and overrides the actual score since we deem it AOK
scastlara
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where projects that have "acknowledged" vulnerabilities only show up in the acknowledged section of the general report, thus hiding that they still make have critical/high vulnerabilities.
Vulnerabilities should be sorted by severity kind instead of severity score. This is because the acknowledged kind is computed by us, and overrides the actual score since we deem it AOK
I did not add any tests, at this point it is not simple... #49