ToucheggBackend: Use Priority.DEFAULT for sending events to the main thread #2284
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason behind this (from #2258):
Ok I did some more investigation. Turns out that the reason is that in our toucheggbackend we receive events in a different thread and send them via idle to the main thread. So far so good. However we use Priority.DEFAULT_IDLE (we don't set anything) which might cause them to be stuck behind other more important events. This is the case when we do update_hover_widgets in the window clone because there they get animated via set_easing etc. which seemingly blocks lower priority events. This sometimes causes a delay which seems like a lag.