Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show notifications on the left in RTL languages #1812

Merged
merged 2 commits into from
Jan 1, 2024
Merged

Show notifications on the left in RTL languages #1812

merged 2 commits into from
Jan 1, 2024

Conversation

lenemter
Copy link
Member

Fixes #765

@lenemter lenemter requested a review from a team December 24, 2023 07:32
danirabbit
danirabbit approved these changes Jan 1, 2024
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm this works as expected :)

@danirabbit danirabbit enabled auto-merge (squash) January 1, 2024 21:00
@danirabbit danirabbit merged commit 7de779c into master Jan 1, 2024
4 checks passed
@danirabbit danirabbit deleted the lenemter/rtl-notifications branch January 1, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danirabbit danirabbit danirabbit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The notifications appear on the right side, they should be in Arabic on the left
2 participants
@lenemter @danirabbit