Add pinch to screenshot gesture #1804
Conversation
| switch_workspace_with_gesture = three_fingers_move_to_workspace || four_fingers_move_to_workspace; | ||
| if (switch_workspace_with_gesture) { | ||
| if (switch_workspace_with_gesture && is_horizontal_direction) { |
There was a problem hiding this comment.
This looks to be the same check as on 552?
|
I've been trying to figure out for a while why I'm feeling negatively about this, and I think I figured it out. For all of the other swipe gestures, the action has a continuous 1:1 response. So for example swiping to switch a workspace your getting continuous feedback as the action happens. But here there's no way to have a kind of continuous feedback for a very discrete action. So the gesture feels kind of unrelated to the thing that happens in response to the gesture. I wonder for some action like this if it would be better to have like a double tap with 3 fingers or something like that |
I can see that. Though I could also imagine the gesture causing some sort of overlay to appear, "framing" the shot so to speak, that way there's visual feedback to the gesture, and if you swipe quick you just don't see it or something. But that is like a pipe dream kind of implementation. |
|
I'll close the PR for now and revisit pinch gesture ideas later. |
I think it's a good gesture for a pinch, which currently is used only for zoom.