Implement changes to memberlist from feedback #29029
Merged
+180
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ThreePidInviteTile now contains an user label showing "(Invited)" and an email icon. - RoomMemberTile now includes an icon similar to above. - Refactors a bunch of code to make this change sensible.
t3chguy
requested changes
Jan 21, 2025
There was a problem hiding this comment.
What is the rule for the MXID being shown? Its very confusing there are two Bob's but only one is disambiguated.
There was a problem hiding this comment.
Yes, I would also expect them both to be disambiguated. But this is a long standing bug: #468
src/components/views/rooms/MemberList/tiles/common/InvitedIconView.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
t3chguy
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes /~https://github.com/element-hq/wat-internal/issues/246
Following changes are made:
(Invite)label. This is now fixed.