Docker: run as non-root #28849
Merged
Docker: run as non-root #28849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
richvdh
force-pushed
the
rav/docker/unprivileged
branch
from
d1fc79d to
076f93d
Compare
dbkr
reviewed
Jan 3, 2025
dbkr
approved these changes
Jan 3, 2025
remram44
added a commit
to remram44/matrix-helm
that referenced
this pull request
Jan 4, 2025
Now that it doesn't run as root: element-hq/element-web#28849
schildbach
reviewed
Jan 7, 2025
Comment on lines
+29
to
+33
| RUN sed -i -e 's,/var/run/nginx.pid,/tmp/nginx.pid,' /etc/nginx/nginx.conf | ||
|
|
||
| # nginx user must own the cache and etc directory to write cache and tweak the nginx config | ||
| RUN chown -R nginx:0 /var/cache/nginx /etc/nginx | ||
| RUN chmod -R g+w /var/cache/nginx /etc/nginx |
There was a problem hiding this comment.
Rather than having to maintain two tmp file systems (/tmp and /var/cache), why not move both to the same place, e.g. /tmp?
(Sadly it seems impossible to prevent the creation of a PID file at all.)
There was a problem hiding this comment.
Ah, and by the way rather than modifying the config via a scary regexp you could just launch nginx via a parameter override:
nginx -g "pid /tmp/nginx.pid;"
There was a problem hiding this comment.
I tried to contribute under terms of AGPL-3.0, but I won't sign CLAs.
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Jan 15, 2025
https://build.opensuse.org/request/show/1238072 by user dheidler + anag+factory - Version 1.11.90 ## ✨ Features * Docker: run as non-root (element-hq/element-web#28849). Contributed by @richvdh. * Docker: allow configuration of HTTP listen port via env var (element-hq/element-web#28840). Contributed by @richvdh. * Update matrix-wysiwyg to consume WASM asset (element-hq/element-web#28838). Contributed by @t3chguy. * OIDC settings tweaks (element-hq/element-web#28787). Contributed by @t3chguy. * Delabs native OIDC support (element-hq/element-web#28615). Contributed by @t3chguy. * Move room header info button to right-most position (element-hq/element-web#28754). Contributed by @t3chguy. * Enable key backup by defa
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Jan 15, 2025
https://build.opensuse.org/request/show/1238071 by user dheidler + anag+factory - Version 1.11.90 ## ✨ Features * Docker: run as non-root (element-hq/element-web#28849). Contributed by @richvdh. * Docker: allow configuration of HTTP listen port via env var (element-hq/element-web#28840). Contributed by @richvdh. * Update matrix-wysiwyg to consume WASM asset (element-hq/element-web#28838). Contributed by @t3chguy. * OIDC settings tweaks (element-hq/element-web#28787). Contributed by @t3chguy. * Delabs native OIDC support (element-hq/element-web#28615). Contributed by @t3chguy. * Move room header info button to right-most position (element-hq/element-web#28754). Contributed by @t3chguy. * Enable key backup by defa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes: The docker image now runs as a non-root user
Empirically, listening on port 80 with non-root works just fine nowadays, so we may as well do that.
The hacks toTurns out we don't need many hacks, for our usecase.nginx.confare based on "Running nginx as a non-root user" in https://hub.docker.com/_/nginx (and the dockerfile fornginxinc/nginx-unprivileged).Based on #28840Fixes #25926