Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight grab-bag of fixes for electron on Windows #2551

Merged
merged 1 commit into from
Nov 7, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions electron/src/electron-main.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,12 @@ See the License for the specific language governing permissions and
limitations under the License.
*/

// Squirrel on windows starts the app with various flags
// as hooks to tell us when we've been installed/uninstalled
// etc.
const check_squirrel_hooks = require('./squirrelhooks');
if (check_squirrel_hooks()) return;

const electron = require('electron');
const url = require('url');

Expand All @@ -29,6 +35,7 @@ const PERMITTED_URL_SCHEMES = [
];

const UPDATE_POLL_INTERVAL_MS = 60 * 60 * 1000;
const INITIAL_UPDATE_DELAY_MS = 30 * 1000;

let mainWindow = null;
let appQuitting = false;
Expand Down Expand Up @@ -107,15 +114,18 @@ electron.app.on('ready', () => {
// do it in the main process (and we don't really need to check every 10 minutes:
// every hour should be just fine for a desktop app)
// However, we still let the main window listen for the update events.
pollForUpdates();
// We also wait a short time before checking for updates the first time because
// of squirrel on windows and it taking a small amount of time to release a
// lock file.
setTimeout(pollForUpdates, INITIAL_UPDATE_DELAY_MS);
setInterval(pollForUpdates, UPDATE_POLL_INTERVAL_MS);
} catch (err) {
// will fail if running in debug mode
console.log("Couldn't enable update checking", err);
}

mainWindow = new electron.BrowserWindow({
icon: `${__dirname}/../../vector/img/logo.png`,
icon: `${__dirname}/../img/riot.ico`,
width: 1024, height: 768,
});
mainWindow.loadURL(`file://${__dirname}/../../vector/index.html`);
Expand Down
15 changes: 14 additions & 1 deletion electron/src/vectormenu.js
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,20 @@ if (process.platform === 'darwin') {
role: 'front'
}
]
};
} else {
template.unshift({
label: 'File',
submenu: [
// For some reason, 'about' does not seem to work on windows.
/*{
role: 'about'
},*/
{
role: 'quit'
}
]
});
}

module.exports = electron.Menu.buildFromTemplate(template)

8 changes: 6 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@
"catw": "^1.0.1",
"cpx": "^1.3.2",
"css-raw-loader": "^0.1.1",
"electron-builder": "^7.10.2",
"electron-builder": "^7.23.2",
"emojione": "^2.2.3",
"expect": "^1.16.0",
"fs-extra": "^0.30.0",
Expand Down Expand Up @@ -132,9 +132,13 @@
"files": [
"!**/*",
"electron/src/**",
"electron/img/**",
"vector/**",
"package.json"
]
],
"squirrelWindows": {
"iconUrl": "https://riot.im/favicon.ico"
}
},
"directories": {
"buildResources": "electron/build",
Expand Down