App load tweaks, improve error pages #13329
Conversation
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
…-im/riot-web into t3chguy/app_load4
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
…x and chrome Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
…n bundle and s/CompatibilityPage/CompatibilityView/ Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
|
|
| @@ -49,7 +49,7 @@ | |||
| <% } | |||
| } %> | |||
| </head> | |||
| <body style="height: 100%;" data-vector-indexeddb-worker-script="<%= htmlWebpackPlugin.files.chunks['indexeddb-worker'].entry %>"> | |||
| <body style="height: 100%; margin: 0;" data-vector-indexeddb-worker-script="<%= htmlWebpackPlugin.files.chunks['indexeddb-worker'].entry %>"> | |||
There was a problem hiding this comment.
a bit unclear what this change is doing, but probably fine
There was a problem hiding this comment.
its fixing the margin around the ErrorView and CompatibilityView in Chrome which has a default margin for when our react-sdk css doesn't get loaded yet.
| <p class="mx_Spacer"><strong>Android</strong></p> | ||
| <a href="https://play.google.com/store/apps/details?id=im.vector.app" target="_blank" | ||
| class="mx_ClearDecoration"> | ||
| <svg width="162px" height="48px" viewBox="0 0 162 48" version="1.1" |
There was a problem hiding this comment.
We really need to not have these SVGs here. If we can't import them then we should at least use relative references.
There was a problem hiding this comment.
We have them in the mobile_guide, its by Nad's design to be an inline page to make it as not brittle as possible.
There was a problem hiding this comment.
Yeah, the original requirement for mobile_guide was that the page was self encapsulated and portable for implementation ease. If we want to factor the SVG's out that's fine by me, but will leave it to yourselves on technical review.
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Co-Authored-By: Travis Ralston <travpc@gmail.com>
Fixes #792
Needs merging in lock-step with matrix-org/matrix-react-sdk#4462
Pending work:
Incompatible browser:
Incompatible browser and React failed to load:
Invalid config.json:
Something went HUGELY wrong but Modernizr seems to be happy with the browser
