-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add contribute.json #12251
Add contribute.json #12251
Conversation
This document is required for example for all Mozilla websites and makes sense for Riot to also describe itself - see https://www.contributejson.org/ Signed-off-by: Jason Robinson <jasonr@matrix.org>
res/contribute.json
Outdated
@@ -0,0 +1,17 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the docs it should be at the project root?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's copied into webapp
in the build here and as such is in the same place as config.json
if I've understood the build process correctly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the build tools can pull from there too, though it'll also need adding to the files
in the package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the build tools can pull from there too, though it'll also need adding to the
files
in the package.json
res
is already in files - will that do? I verified yarn build
does end up copying the file, but if it's needed explicitly somewhere else can add.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem has nothing to do with the build process: I literally mean move this file up one directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I seriously have had enough coffee but somehow managed to totally misunderstand everything you clearly wrote while juggling other things. Fixed now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries, thanks!
Signed-off-by: Jason Robinson <jasonr@matrix.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like a thing we should have. If people disagree, they should speak up.
* Add A-Element-R labels to rageshakes if rust * fix import * Add tests for rageshake collect * add ts-ignore in test * refactor rageshake to match sonar Cognitive Complexity
This document is required for example for all Mozilla websites.
Might make sense for Riot sites to also describe themselves?
See: https://www.contributejson.org/
Signed-off-by: Jason Robinson jasonr@matrix.org