Merge pull request #9352 from vector-im/travis/save-as-2

Don't try to save files the user didn't want to save
element-hq · Apr 2, 2019 · 958260d · 958260d
2 parents 95e247a + 8b2d33a
commit 958260d
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/electron_app/src/webcontents-handler.js b/electron_app/src/webcontents-handler.js
@@ -96,13 +96,14 @@ function onLinkContextMenu(ev, params) {
                     defaultPath: targetFileName,
                 });
 
+                if (!filePath) return; // user cancelled dialog
+
                 try {
                     if (url.startsWith("data:")) {
                         fs.writeFileSync(filePath, nativeImage.createFromDataURL(url));
                     } else {
                         request.get(url).pipe(fs.createWriteStream(filePath));
                     }
-
                 } catch (err) {
                     console.error(err);
                     dialog.showMessageBox({