Draft: Try to fix tests on Windows #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed 2 tests! |
electrikmilk
changed the title
NoelTautges
reviewed
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since you can use the
--hubsignoption on Windows to sign Shortcuts, I'd like to see if I can iron out any cross platform issues.While Cherri has primarily been developed for a Unix environment, it's still programmed in Golang which is cross platform. Also, the final Shortcut will be signed by a Mac, so we don't need to worry about the output, just parsing, etc.
Disclaimer however, this does not guarantee we will actively monitor our support for Windows. The project has other priorities that will usually continue to take precedence.
I just wanted to try to get it to work on Windows even if it will likely never be super comfortable to develop Shortcuts on a non-Apple platform, I'd like to at least make it so that it's easy enough to fix minor Windows platform issues in the future, even if we don't always get to them.