Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Streams 🌊] Fix _sample API condition param and missing typing on processor forms #207213

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[Streams 🌊] Fix _sample API condition param and missing typing on processor forms #207213

wants to merge 3 commits into from
+63 −31

Conversation

tonyghiani
Copy link
Contributor

@tonyghiani tonyghiani commented Jan 20, 2025 •
edited
Loading

📓 Summary

Address a reference error on the optional condition parameter for the _sample API and add explicit typing to processor forms' controls.

@tonyghiani
Copy link
Contributor Author

/ci

@tonyghiani tonyghiani added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Streams This is the label for the Streams Project labels Jan 20, 2025
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #7 / GraphInvestigation Component shows error on bad kql syntax

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
streamsApp 272.5KB 272.8KB +295.0B

@tonyghiani tonyghiani marked this pull request as ready for review January 20, 2025 16:39
@tonyghiani tonyghiani requested a review from a team as a code owner January 20, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Streams This is the label for the Streams Project release_note:skip Skip the PR/issue when compiling release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tonyghiani @elasticmachine