Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use client logger in ContentInsightsClient #207206

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Use client logger in ContentInsightsClient #207206

wants to merge 2 commits into from
+41 −7

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented Jan 20, 2025

Summary

fix /~https://github.com/elastic/kibana-team/issues/1412 (see context, just for sanity)

@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 20, 2025 •
edited
Loading

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!

Dosant
Dosant commented Jan 20, 2025
View reviewed changes
src/platform/plugins/shared/dashboard/public/services/logger.ts

export let logger: Logger;

export const setLogger = (_logger: Logger) => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure if to have it separate like this or to add to existing setKibanaServices, I opted for a separate because logger isn't part of CoreStart but available on plugin initialize context. It also can be usefull before start phase. But lmk if I should change this and merge into setKibanaServices

@Dosant Dosant mentioned this pull request Jan 20, 2025
Draft
@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 20, 2025 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #17 / GraphInvestigation Component shows error on bad kql syntax
  • [job] [logs] Jest Tests #17 / GraphInvestigation Component shows error on bad kql syntax

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
dashboard 696 697 +1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/content-management-content-insights-public 29 30 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 624.1KB 624.3KB +208.0B
visualizations 354.2KB 354.2KB -4.0B
total +204.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dashboard 18.2KB 18.3KB +168.0B
Unknown metric groups

API count

id before after diff
@kbn/content-management-content-insights-public 34 35 +1

ESLint disabled line counts

id before after diff
@kbn/content-management-content-insights-public 1 0 -1

Total ESLint disabled count

id before after diff
@kbn/content-management-content-insights-public 1 0 -1

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dosant @elasticmachine @kibanamachine