[React@18] Fix remaining unit tests #207195
Open
+6
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dosant
commented
Jan 20, 2025
| return { | ||
| ...origin, | ||
| useDispatch: jest.fn(), | ||
| useDispatch: jest.fn(() => mockDispatch), |
There was a problem hiding this comment.
| } | ||
| return prevTimelineTypes; | ||
| }); | ||
| setTimelineTypes(tabId); |
There was a problem hiding this comment.
This fixes
Given the failed test, it seems there was a genuine runtime bug with React@18. It appears that the behavior of this pattern has changed in React@18 compared to React@17. I suspect that the original logic was lost over several refactorings and there is no need to nest setState in the same setState anymore, but please doublecheck
Dosant
added
Team:SharedUX
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
5 tasks
Dosant
changed the title
security-threat-hunting-investigations
Dosant
commented
Jan 20, 2025
| await waitFor(async () => { | ||
| await expect(findAllByTestId('trustedAppsListPage-card')).resolves.toHaveLength(10); | ||
| expect(getAllByTestId('trustedAppsListPage-card')).toHaveLength(10); |
szwarckonrad
approved these changes
Jan 20, 2025
💚 Build Succeeded
Metrics [docs]Async chunks
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #206952
Fixes remaining unit tests that are failing with React@18
The idea is that tests should pass with both React 17 and 18. To run a unit tests with React@18: