Update knn search and query template autocomplete #207187
Merged
+49
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosdelest
added
release_note:enhancement
Feature:Dev Tools
v9.0.0
auto-backport
carlosdelest
added
the
backport:prev-minor
ElenaStoeva
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
Thanks for updating these autocomplete definitions @carlosdelest! Changes lgtm, tested in Console.
|
Starting backport for target branches: 8.x /~https://github.com/elastic/kibana/actions/runs/12872982005 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 20, 2025
(cherry picked from commit 1dc2aca)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 20, 2025
…07247) # Backport This will backport the following commits from `main` to `8.x`: - [Update knn search and query template autocomplete (#207187)](#207187) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](/~https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Carlos Delgado","email":"6339205+carlosdelest@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-01-20T17:18:58Z","message":"Update knn search and query template autocomplete (#207187)","sha":"1dc2aca8ee7692a61218039b3747e8e305ace0c4","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Feature:Dev Tools","v9.0.0","Team:Search","auto-backport","backport:prev-minor","v8.18.0"],"title":"Update knn search and query template autocomplete","number":207187,"url":"/~https://github.com/elastic/kibana/pull/207187","mergeCommit":{"message":"Update knn search and query template autocomplete (#207187)","sha":"1dc2aca8ee7692a61218039b3747e8e305ace0c4"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"/~https://github.com/elastic/kibana/pull/207187","number":207187,"mergeCommit":{"message":"Update knn search and query template autocomplete (#207187)","sha":"1dc2aca8ee7692a61218039b3747e8e305ace0c4"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Carlos Delgado <6339205+carlosdelest@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Does what it says on the tin - updates autocomplete for knn search and knn query with vector rescoring introduced in elastic/elasticsearch#119835
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:*label is applied per the guidelines