Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Update CODEOWNERS for the Security Engineering Productivity team #170662

Conversation

banderror
Copy link
Contributor

Summary

This PR makes the @elastic/security-engineering-productivity team the owner of the x-pack/test/security_solution_cypress/package.json file to prevent accidentally merging temporary changes to this file like in #169182.

Also, it simplifies the ownership rules a bit. The following lines assign the team to all files under the two specified folders, but not files inside their subfolders, so you don't have to specify individual files:

/x-pack/test/security_solution_cypress/* @elastic/security-engineering-productivity
/x-pack/test/security_solution_cypress/cypress/* @elastic/security-engineering-productivity

@banderror banderror added technical debt Improvement of the software architecture and operational architecture Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team labels Nov 6, 2023
@banderror banderror self-assigned this Nov 6, 2023
@banderror banderror marked this pull request as ready for review November 6, 2023 16:41
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@banderror banderror added release_note:skip Skip the PR/issue when compiling release notes v8.12.0 labels Nov 6, 2023
Copy link
Member

@MadameSheema MadameSheema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of thanks for taking the time on this!! :)

@banderror banderror enabled auto-merge (squash) November 6, 2023 16:45
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #64 / Agents fleet_upgrade_agent "before each" hook for "should respond 400 if trying to upgrade an agent that is unenrolling"

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @banderror

@banderror banderror merged commit 38ad5d8 into elastic:main Nov 6, 2023
13 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 6, 2023
@banderror banderror deleted the codeowners-for-security-solution-cypress-package-json branch November 7, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. technical debt Improvement of the software architecture and operational architecture v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants