Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues on client subpages before consolidating #256

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

marciw
Copy link
Contributor

@marciw marciw commented Jan 9, 2025

Preview

Quick-fixing some small issues that crept in with other client doc PRs. I'm working on a separate PR to consolidate the client subpages and point to the standard/stack clients instead, so this is just a temporary band-aid. The subpages will go away soon.

  • Remove (now inaccurate) serverless banner on the Go subpage
  • Remove repository links to avoid conflicts with pointers to standard clients
  • Match Java subpage title for now, mostly for brevity in the left nav

Copy link

github-actions bot commented Jan 9, 2025

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@marciw marciw marked this pull request as ready for review January 9, 2025 23:29
@marciw marciw requested a review from a team as a code owner January 9, 2025 23:29
Copy link
Collaborator

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marciw marciw merged commit b9ea321 into elastic:main Jan 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants