Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to proceed runInTerminal request in sidecar container #4533

Merged
merged 1 commit into from
Mar 19, 2019
Merged

Ability to proceed runInTerminal request in sidecar container #4533

merged 1 commit into from
Mar 19, 2019

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Mar 12, 2019 •
edited
Loading

Signed-off-by: Anatoliy Bazko abazko@redhat.com

Reference issue

eclipse-che/che#12771

Method overriding is implemented in eclipse-che/che-theia#107

@tsmaeder tsmaeder mentioned this pull request Mar 12, 2019
Closed
5 tasks
@jankeromnes jankeromnes mentioned this pull request Mar 12, 2019
Closed
akosyakov
akosyakov reviewed Mar 13, 2019
View reviewed changes
packages/debug/src/browser/debug-session.tsx Outdated
@@ -63,7 +64,7 @@ export class DebugSession implements CompositeTreeElement {

constructor(
readonly id: string,
readonly options: DebugSessionOptions,
Copy link
Member

@akosyakov akosyakov Mar 13, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's an API, would be nice to preserve it as options

Also name is very verbose in such way. It is obvious from context that it belongs to DebugSession.

akosyakov
akosyakov reviewed Mar 13, 2019
View reviewed changes
packages/plugin-ext/src/api/plugin-api.ts Outdated
@@ -978,6 +978,7 @@ export interface DebugExt {
$getConfigurationSnippets(debugType: string): Promise<IJSONSchemaSnippet[]>;
$createDebugSession(debugConfiguration: theia.DebugConfiguration): Promise<string>;
$terminateDebugSession(sessionId: string): Promise<void>;
$getTerminalCreationOptions(debugType: string): Promise<any>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be here better type than any, i.e. TerminalOptionsExt | undefined?

@akosyakov
Copy link
Member

How one will be able to test it?

@tolusha tolusha force-pushed the ab/runInSidecarTerminal branch from 0fcd5f8 to e7b375e Compare March 18, 2019 07:09
@tolusha
Proceed runInTermianl request in a sidecar container
d3d458c 
Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
@tolusha tolusha force-pushed the ab/runInSidecarTerminal branch from e7b375e to d3d458c Compare March 18, 2019 10:49
@tolusha tolusha marked this pull request as ready for review March 18, 2019 10:50
@tolusha
Copy link
Contributor Author

tolusha commented Mar 18, 2019

@akosyakov

Debug process was run in a sidecar container

PID   USER     TIME  COMMAND
    1 root      0:02 node /home/theia/lib/node/plugin-remote.js
   48 root      0:00 /usr/local/bin/python completion.py
   51 root      0:00 /usr/local/bin/python lib/python/jedi/evaluate/compiled/subprocess/__main__.py lib/python
  129 root      0:00 node /plugins/ms-python.python.2019.2.5433/extension/out/client/debugger/debugAdapter/main.js
  139 root      0:00 /usr/local/bin/python /plugins/ms-python.python.2019.2.5433/extension/pythonFiles/ptvsd_launche
  163 root      0:00 /bin/ash
  169 root      0:00 ps

akosyakov
akosyakov approved these changes Mar 19, 2019
View reviewed changes
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified that debugging with integrated terminal still works nicely against Theia and VS Code extensions for Node.js

@tolusha tolusha merged commit 8968ac2 into master Mar 19, 2019
@tolusha tolusha deleted the ab/runInSidecarTerminal branch March 19, 2019 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitf benoitf benoitf approved these changes

@akosyakov akosyakov akosyakov approved these changes

@evidolob evidolob Awaiting requested review from evidolob

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tolusha @akosyakov @benoitf