Change ConvertForLoopOperation to avoid getting type from size() method #1618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I confirm this patch fixes eclipse-jdtls/eclipse-jdt-core-incubator#748 , thank you! |
|
@mickaelistria Great. I'll merge it for 4.34 M1 when the branches open. |
jjohnstn
force-pushed
the
forloopchange
branch
from
07c332b to
acd7e11
Compare
- change ConvertForLoopOperation to change the logic that gets the type of size() method call to instead get the type of the expression calling it - fixes eclipse-jdt#1617
jjohnstn
force-pushed
the
forloopchange
branch
from
da909d4 to
6cbfaf6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
See issue.
How to test
Run JDT UI test suite and test with jdtls.
Author checklist