-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#224] implement placement new for containers #230
[#224] implement placement new for containers #230
Conversation
…s not fail when unstable does not compile
e18a35d
to
4bf22d2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #230 +/- ##
==========================================
- Coverage 80.02% 79.67% -0.36%
==========================================
Files 183 186 +3
Lines 20426 20575 +149
==========================================
+ Hits 16346 16393 +47
- Misses 4080 4182 +102
|
2b4b08c
to
f7441c0
Compare
…w for semantic string since it breaks the contract
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just a few nitpicks
4233ef5
to
f964870
Compare
c542e3e
to
1a97e46
Compare
fn placement_default_works() { | ||
let mut sut = RawMemory::<Sut>::new_filled(0xff); | ||
unsafe { Sut::placement_default(sut.as_mut_ptr()) }; | ||
assert_that!(unsafe {sut.assume_init()}, len 0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assert_that!(unsafe {sut.assume_init()}, len 0); | |
let sut = unsafe { sut.assume_init() }; | |
assert_that!(sut, len 0); |
To not have to call assume_init consecutively
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, I would keep it as it is ... so that my future self has something to dislike me for ;)
Notes for Reviewer
Pre-Review Checklist for the PR Author
SPDX-License-Identifier: Apache-2.0 OR MIT
iox2-123-introduce-posix-ipc-example
)[#123] Add posix ipc example
)task-list-completed
)Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Closes #224