Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix recovery of Devfile based workspaces #13321

Merged
merged 2 commits into from
May 15, 2019
Merged

Fix recovery of Devfile based workspaces #13321

merged 2 commits into from
May 15, 2019

Conversation

sleshchenko
Copy link
Member

What does this PR do?

This PR fixes recovery of Devfile based workspaces.
This is done by moving logic of converting Devfile to workspace config form WorkspaceManager to WorkspaceRuntimes, and perform this converting on recovering of workspace if needed.

What issues does this PR fix or reference?

#13313

Release Notes

N/A

Docs PR

N/A

@sleshchenko sleshchenko added kind/bug Outline of a bug - must adhere to the bug report template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels May 13, 2019
@sleshchenko sleshchenko self-assigned this May 13, 2019
@sleshchenko
Fix recovery of Devfile based workspaces
f10746c 
Signed-off-by: Sergii Leshchenko <sleshche@redhat.com>
@sleshchenko sleshchenko force-pushed the recoveryDevfileBasedWorkspaces branch from 92eaa61 to f10746c Compare May 13, 2019 10:59
@sleshchenko
Copy link
Member Author

ci-test

@che-bot

This comment has been minimized.

Sign in to view
@sleshchenko
fixup! Fix recovery of Devfile based workspaces
d9b375a 
Signed-off-by: Sergii Leshchenko <sleshche@redhat.com>
@sleshchenko
Copy link
Member Author

ci-test

@che-bot

This comment has been minimized.

Sign in to view
@sleshchenko
Copy link
Member Author

ci-build

@sleshchenko
Copy link
Member Author

ci-test

@che-bot
Copy link
Contributor

che-bot commented May 14, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13321
/~https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@SkorikSergey
Copy link
Contributor

ci-test

@che-bot
Copy link
Contributor

che-bot commented May 14, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13321
/~https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@SkorikSergey
Copy link
Contributor

ci-test

@che-bot
Copy link
Contributor

che-bot commented May 14, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13321
/~https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@SkorikSergey
Copy link
Contributor

Selenium tests execution on Eclipse Che Multiuser on OCP (https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/1791//Selenium_20tests_20report/) doesn't show any regression against this Pull Request.

@sleshchenko sleshchenko merged commit c574db3 into eclipse-che:master May 15, 2019
@sleshchenko sleshchenko deleted the recoveryDevfileBasedWorkspaces branch May 15, 2019 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metlos metlos metlos approved these changes

@skabashnyuk skabashnyuk skabashnyuk approved these changes

@amisevsk amisevsk amisevsk approved these changes

Assignees

@sleshchenko sleshchenko

Labels
kind/bug Outline of a bug - must adhere to the bug report template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sleshchenko @che-bot @SkorikSergey @metlos @skabashnyuk @amisevsk