Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Display non-tooling containers and add buton to display all containers #357

Closed
wants to merge 2 commits into from

Conversation

vzhukovs
Copy link
Contributor

What does this PR do?

This changes proposal filters containers to display non-tooling at first step and adds additional item into list to load all containers, including tooling.

machine-picker

Signed-off-by: Vladyslav Zhukovskyi vzhukovs@redhat.com

What issues does this PR fix or reference?

eclipse-che/che#13390

Release Notes

Provide curated list of containers to run tasks

Docs PR

@vzhukovs vzhukovs added kind/enhancement New feature or request team/ide labels Jul 19, 2019
@vzhukovs vzhukovs self-assigned this Jul 19, 2019
@vparfonov vparfonov added this to the 7.1.0 milestone Jul 19, 2019
@che-bot
Copy link
Contributor

che-bot commented Sep 4, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@benoitf
Copy link
Contributor

benoitf commented Sep 19, 2019

hi,

what is the status of this PR ? no review yet ?

@sunix
Copy link
Contributor

sunix commented Oct 7, 2019

My only concern is that this is not consistent with the terminal flow. For terminal we use hot keys, but not for running tasks. I am not sure i have understood the reasons.

@che-bot
Copy link
Contributor

che-bot commented Oct 24, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@che-bot
Copy link
Contributor

che-bot commented Oct 24, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • logs and configs
  • "che-theia" docker image: maxura/che-theia:357
  • "che-theia-endpoint-runtime" docker image: maxura/che-theia-endpoint-runtime:357
  • "che-remote-plugin-runner-java8" docker image: maxura/che-remote-plugin-runner-java8:357
  • "che-remote-plugin-kubernetes-tooling-1.0.0" docker image: maxura/che-remote-plugin-kubernetes-tooling-1.0.0:357
  • Happy path tests DevFile

@che-bot
Copy link
Contributor

che-bot commented Oct 24, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • logs and configs
  • "che-theia" docker image: maxura/che-theia:357
  • "che-theia-endpoint-runtime" docker image: maxura/che-theia-endpoint-runtime:357
  • "che-remote-plugin-runner-java8" docker image: maxura/che-remote-plugin-runner-java8:357
  • "che-remote-plugin-kubernetes-tooling-1.0.0" docker image: maxura/che-remote-plugin-kubernetes-tooling-1.0.0:357
  • Happy path tests DevFile

@che-bot
Copy link
Contributor

che-bot commented Oct 24, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • logs and configs
  • "che-theia" docker image: maxura/che-theia:357
  • "che-theia-endpoint-runtime" docker image: maxura/che-theia-endpoint-runtime:357
  • "che-remote-plugin-runner-java8" docker image: maxura/che-remote-plugin-runner-java8:357
  • "che-remote-plugin-kubernetes-tooling-1.0.0" docker image: maxura/che-remote-plugin-kubernetes-tooling-1.0.0:357
  • Happy path tests DevFile

@che-bot
Copy link
Contributor

che-bot commented Oct 24, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • logs and configs
  • "che-theia" docker image: maxura/che-theia:357
  • "che-theia-endpoint-runtime" docker image: maxura/che-theia-endpoint-runtime:357
  • "che-remote-plugin-runner-java8" docker image: maxura/che-remote-plugin-runner-java8:357
  • "che-remote-plugin-kubernetes-tooling-1.0.0" docker image: maxura/che-remote-plugin-kubernetes-tooling-1.0.0:357
  • Happy path tests DevFile

@RomanNikitenko
Copy link
Member

May be it makes sense to improve the behavior for case when user has only tooling containers
https://youtu.be/Ic2kRf2D5bQ
WDYT?

…w all

Signed-off-by: Vlad Zhukovskyi <vzhukovs@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Oct 24, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@che-bot
Copy link
Contributor

che-bot commented Oct 24, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

Signed-off-by: Vlad Zhukovskyi <vzhukovs@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Oct 28, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • logs and configs
  • "che-theia" docker image: maxura/che-theia:357
  • "che-theia-endpoint-runtime" docker image: maxura/che-theia-endpoint-runtime:357
  • "che-remote-plugin-runner-java8" docker image: maxura/che-remote-plugin-runner-java8:357
  • "che-remote-plugin-kubernetes-tooling-1.0.0" docker image: maxura/che-remote-plugin-kubernetes-tooling-1.0.0:357
  • Happy path tests DevFile

@vzhukovs
Copy link
Contributor Author

vzhukovs commented Nov 4, 2019

Closing this PR due to not actual changes. The are two PR opened:
#532
eclipse-theia/theia#6487

@vzhukovs vzhukovs closed this Nov 4, 2019
@vzhukovs vzhukovs deleted the machine branch November 4, 2019 13:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/enhancement New feature or request team/ide
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants