This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 111
Include vscode git extension to default plugins #328
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunix
reviewed
Jul 4, 2019
dockerfiles/theia/Dockerfile
Outdated
@@ -107,6 +107,8 @@ EXPOSE 3100 3130 | |||
|
|||
COPY --from=builder /home/theia-dev/theia-source-code/production/plugins /default-theia-plugins | |||
|
|||
RUN wget -P /default-theia-plugins /~https://github.com/che-incubator/vscode-git/releases/download/1.30.1/vscode-git-1.3.0.1.vsix | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Signed-off-by: Igor Vinokur <ivinokur@redhat.com>
benoitf
approved these changes
Jul 4, 2019
@vinokurig FYI it would require also a backport to 7.0.0 branch as it's required for Che 7.0 GA |
@benoitf Ok, I'll create a PR, thanks |
vinokurig
added a commit
that referenced
this pull request
Jul 5, 2019
* Downloads vscode git extension package to default plugins directory. * Update theia-generator version to one without native theia git extension
vinokurig
added a commit
that referenced
this pull request
Jul 5, 2019
* Downloads vscode git extension package to default plugins directory. * Update theia-generator version to one without native theia git extension
vinokurig
added a commit
that referenced
this pull request
Jul 5, 2019
monaka
pushed a commit
to PizzaFactory/che-theia
that referenced
this pull request
Jul 7, 2019
* Downloads vscode git extension package to default plugins directory. * Update theia-generator version to one without native theia git extension
monaka
pushed a commit
to PizzaFactory/che-theia
that referenced
this pull request
Jul 7, 2019
* Downloads vscode git extension package to default plugins directory. * Update theia-generator version to one without native theia git extension
vinokurig
added a commit
that referenced
this pull request
Jul 9, 2019
* Downloads vscode git extension package to default plugins directory. * Update theia-generator version to one without native theia git extension
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Downloads vscode git extension package to default plugins directory.
Update
theia-generator
version to one without native theia git extension (Exclude native Theia Git extension ws-skeleton/che-theia-generator#28)/~https://github.com/eclipse/che-theia/blob/ffbef321470fff581c1fd78a45b1decf4124ecc5/dockerfiles/theia-dev/Dockerfile#L42
What issues does this PR fix or reference?
Is needed for eclipse-che/che#11867
Release Notes
Docs PR