-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix outdated workspace nodeSelector documentation #2690
Conversation
🎊 Navigate the preview: https://65d467d0f77d09a7000bc820--eclipse-che-docs-pr.netlify.app 🎊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
---- | ||
This section must contain a set of `key=value` pairs to form the nodeSelector rule. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vinokurig please, provide an example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The snippet above is already an example. The key:value
pair is a random pair that must match the corresponding node's labael.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vinokurig could you please provide an example for nodeSelector, also as part of this issue could you please add a procedure for adding tolerations
This paragraph is outdated, |
|
What does this pull request change?
Fix outdated workspace nodeSelector documentation:

What issues does this pull request fix or reference?
fixes eclipse-che/che#22801
Specify the version of the product this pull request applies to
latest
Pull Request checklist
The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.
Validate language on files added or modified
step reports no vale warnings.