Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix outdated workspace nodeSelector documentation #2690

Merged
merged 4 commits into from
Feb 20, 2024
Merged

Fix outdated workspace nodeSelector documentation #2690

merged 4 commits into from
Feb 20, 2024

Conversation

vinokurig
Copy link
Contributor

@vinokurig vinokurig commented Feb 19, 2024

What does this pull request change?

Fix outdated workspace nodeSelector documentation:
screenshot-0 0 0 0_4000-2024 02 20-09_25_40

What issues does this pull request fix or reference?

fixes eclipse-che/che#22801

Specify the version of the product this pull request applies to

latest

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
    • The page contains a redirection for the previous URL.
    • Propagate the URL change in:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

@vinokurig vinokurig requested review from deerskindoll and a team as code owners February 19, 2024 11:47
@vinokurig vinokurig requested a review from amisevsk February 19, 2024 11:47
Copy link

github-actions bot commented Feb 19, 2024

Click here to review and test in web IDE: Contribute

Copy link

github-actions bot commented Feb 19, 2024

🎊 Navigate the preview: https://65d467d0f77d09a7000bc820--eclipse-che-docs-pr.netlify.app 🎊

Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

----
This section must contain a set of `key=value` pairs to form the nodeSelector rule.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vinokurig please, provide an example

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The snippet above is already an example. The key:value pair is a random pair that must match the corresponding node's labael.

Copy link
Member

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vinokurig could you please provide an example for nodeSelector, also as part of this issue could you please add a procedure for adding tolerations

@tolusha
Copy link
Contributor

tolusha commented Feb 20, 2024

Pass the name of this newly created `StorageClass` to {prod-short} through the `+CHE_INFRA_KUBERNETES_PVC_STORAGE__CLASS__NAME+` environment variable. A default empty value of this variable instructs {prod-short} to use the cluster's default `StorageClass`.

This paragraph is outdated,
How to configure storage classes [1]
[1] https://eclipse.dev/che/docs/stable/administration-guide/configuring-storage/

@vinokurig
Copy link
Contributor Author

@tolusha

This paragraph is outdated,

fixed, see the new block:
screenshot-0 0 0 0_4000-2024 02 20-10_34_12

@vinokurig vinokurig merged commit bdd2ffa into main Feb 20, 2024
10 checks passed
@vinokurig vinokurig deleted the che-22801 branch February 20, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Doc Bug: Eclipse Che Documentation contains outdated config for "Configuring workspaces nodeSelector"
5 participants