Skip to content
This repository has been archived by the owner on May 7, 2020. It is now read-only.

Add i18n support to LIFX #3312

Merged
merged 1 commit into from
Apr 26, 2017
Merged

Add i18n support to LIFX #3312

merged 1 commit into from
Apr 26, 2017

Conversation

wborn
Copy link
Contributor

@wborn wborn commented Apr 25, 2017

This PR adds i18n support to the LIFX Binding with English and Dutch translations.
I've also corrected 2016 to 2017 in some copyright headers.

Signed-off-by: Wouter Born <eclipse@maindrain.net>
@kaikreuzer
Copy link
Contributor

I am not quite clear about why you need the ChannelFactory at all - I would have assumed that our i18n infrastructure also supports the localization of channel (types) out of the box?

See e.g. the Yahoo binding, which also has localized channels.

Am I missing something?

@wborn
Copy link
Contributor Author

wborn commented Apr 26, 2017

@kaikreuzer The ChannelFactory is only used for the dynamic channels to get the correct zone index in the channel labels and descriptions.

The complexity could be reduced by removing the ChannelFactory but then all these channels will have the same labels and descriptions.

That may not necessarily be an issue because they are advanced channels and users can still identify them with the ChannelUID.

@kaikreuzer
Copy link
Contributor

Ah, that's what I had missed then - thanks for the clarification, makes sense!

@kaikreuzer kaikreuzer merged commit dc49b62 into eclipse-archived:master Apr 26, 2017
@wborn wborn deleted the lifx-i18n branch April 26, 2017 20:12
@kaikreuzer kaikreuzer modified the milestone: 0.9.0 Jun 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants