This repository has been archived by the owner on May 7, 2020. It is now read-only.
fix NPE in Configuration.toString() #3169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes eclipse-archived#3167 Signed-off-by: Simon Kaufmann <simon.kfm@googlemail.com>
maggu2810
approved these changes
Mar 22, 2017
| @@ -221,7 +221,7 @@ public String toString() { | |||
| sb.append(", "); | |||
| } | |||
| sb.append(String.format("{key=%s; type=%s; value=%s}", prop.getKey(), | |||
| prop.getValue().getClass().getSimpleName(), prop.getValue())); | |||
| prop.getValue() != null ? prop.getValue().getClass().getSimpleName() : "?", prop.getValue())); | |||
There was a problem hiding this comment.
I prefer to use a temp. variable instead of calling the method getValue() three times if only one call is necessary. 😉
There was a problem hiding this comment.
good point - why did you merge it then? 😉
-> #3171
There was a problem hiding this comment.
Because the code itself is okay and I have not been sure, if such stuff is a good reason to not approve the changes.
sjsf
pushed a commit
to sjsf/smarthome
that referenced
this pull request
Mar 22, 2017
...as correctly pointed out in eclipse-archived#3169 relates to eclipse-archived#3169 Signed-off-by: Simon Kaufmann <simon.kfm@googlemail.com>
maggu2810
pushed a commit
that referenced
this pull request
Mar 22, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3167
Signed-off-by: Simon Kaufmann simon.kfm@googlemail.com