-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UniPC Sampler support #12
Conversation
useful links: automatic1111 feature request: |
@@ -34,6 +34,7 @@ def generate_images( | |||
hypernetwork_strength: float = 0, | |||
|
|||
callback=None, | |||
sampler_params={} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a trailing comma (,)
'lower_order_final': True, | ||
'thresholding': False, | ||
}, | ||
'unipc_snr': { #same as suggested version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need duplicate entries? Maybe we can keep a single entry here (the snr one), and update the documentation to recommend one?
Hi @Schorny , thanks for this PR! Nice work!
Please ensure (if you haven't already) that good defaults are used, if no sampler params are passed. Once this PR is merged, we can look at the Easy Diffusion UI separately. Thanks again! |
Hi @Schorny Thanks for this. IMO, the PR is only pending the folder structure change. No hurry or pressure, just trying to avoid any miscommunication. |
Merged this to a branch, will test it out, thanks! |
this is more a discussion than a finalized PR
UniPC is the first sampler that is implemented locally in sdkit, not just imported. so we need a good location and naming guideline.
UniPC is also highly customizable with a few settings. how to expose them to the api?
we need good sample settings. i did a testrun with random settings and figured that
lower_order_final should always be True
thresholding should always be False
order=3 seems to be more vibrant sometimes
vary_coeff seems to create more detailed backgrounds
I created my sample settings on a quick look through my generated sample images. there is definitely way more to be done here.