Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix source URLs for ant v1.10.5 - v1.10.7 #9633

Merged
merged 2 commits into from
Jan 14, 2020
Merged

fix source URLs for ant v1.10.5 - v1.10.7 #9633

merged 2 commits into from
Jan 14, 2020

Conversation

Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Jan 9, 2020 •
edited
Loading

10.5 binary distribution is no longer available, 10.6/7 have https errors with wrong hostname as the url redirects to the new one

@Flamefire Flamefire changed the title Add alternative source URLs for forward compatibility [ant] Add alternative source URLs for forward compatibility Jan 9, 2020
@Flamefire
Copy link
Contributor Author

'https://apache.cu.be/ant/binaries' does not work as Python throws a ssl.CertificateError. Shouldn't this be handled by EB and other URLs tried?

@Flamefire Flamefire changed the title [ant] Add alternative source URLs for forward compatibility Fix ant 10.[5-7] URLs Jan 9, 2020
@Flamefire Flamefire force-pushed the 20200109091351_new_pr_ant1100 branch 2 times, most recently from d71b277 to e4732b2 Compare January 9, 2020 16:10
@Flamefire
Copy link
Contributor Author

Test report by @Flamefire
FAILED
Build succeeded for 2 out of 3 (3 easyconfigs in this PR)
taurusi6395.taurus.hrsk.tu-dresden.de - Linux RHEL 7.4, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/c385db2aa9fc893eb476c473c4b79061 for a full test report.

@Flamefire Flamefire force-pushed the 20200109091351_new_pr_ant1100 branch from e4732b2 to f3e444d Compare January 9, 2020 16:56
@Flamefire
Copy link
Contributor Author

Some java packages seem to be missing when building the doc. However it is the same EC as other (older) ECs so I guess they work on someones system

@boegel boegel added the bug fix label Jan 9, 2020
@boegel boegel added this to the next release (4.1.1) milestone Jan 9, 2020
@smoors
Copy link
Contributor

smoors commented Jan 10, 2020

Test report by @smoors
FAILED
Build succeeded for 3 out of 4 (3 easyconfigs in this PR)
node377.hydra.os - Linux centos linux 7.7.1908, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/3a12f6aafc8b7b99727a110ae61ca802 for a full test report.

@Flamefire
Copy link
Contributor Author

@smoors Same issue. Can you try an older ant and see if that builds?

@Flamefire
Copy link
Contributor Author

Bug seems to be known to others at least: https://stackoverflow.com/questions/56750209/how-to-successfully-build-ant-source-code. Building 10.1 does show errors but build succeeds. 10.5 shows more errors and build fails :/

@Flamefire
Copy link
Contributor Author

Flamefire commented Jan 10, 2020 •
edited
Loading

And I traced the issue to a change in 10.2 which produces the following output on build not seen on 10.1:

Standard Doclet version 1.8.0_221
Building tree for all the packages and classes...
/home/h3/s3248973/apache-ant-1.10.2/src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java:1497: error: reference not found
     * @see org.apache.commons.net.ftp.FTPClientConfig
            ^

I then found that the issue is a removed -Xdoclint:none from javadoc command line which runs into https://bugs.openjdk.java.net/browse/JDK-8224266 and similar to hamcrest/JavaHamcrest#75

Oh there is an upstream bug: https://bz.apache.org/bugzilla/show_bug.cgi?id=63438

@Flamefire
Copy link
Contributor Author

Patch added, built successfully here :)

boegel
boegel requested changes Jan 11, 2020
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also: homepage in ant-1.10.5-Java-1.8.eb should be https://

easybuild/easyconfigs/a/ant/ant-fix-doclint-error.patch Outdated Show resolved Hide resolved
@Flamefire Flamefire force-pushed the 20200109091351_new_pr_ant1100 branch from 6918326 to 8763211 Compare January 13, 2020 09:31
@easybuilders easybuilders deleted a comment from boegelbot Jan 13, 2020
@Flamefire Flamefire force-pushed the 20200109091351_new_pr_ant1100 branch from 8763211 to b1f9edd Compare January 13, 2020 12:34
@Flamefire Flamefire force-pushed the 20200109091351_new_pr_ant1100 branch from b1f9edd to 7ba00cc Compare January 13, 2020 12:39
@boegel boegel changed the title Fix ant 10.[5-7] URLs fix source URLs for ant v1.10.5 - v1.10.7 Jan 14, 2020
@Flamefire
Copy link
Contributor Author

@boegel "source URLs" is wrong as binary URLs are fixed too

@boegel
Copy link
Member

boegel commented Jan 14, 2020

@Flamefire With "source URLs" I mean the value for the source_urls easyconfig parameter.

@boegel
Copy link
Member

boegel commented Jan 14, 2020

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
node2509.golett.os - Linux centos linux 7.7.1908, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/0ceed7fdeabbc6baf6aec1f0ba27b1fa for a full test report.

@boegel
Copy link
Member

boegel commented Jan 14, 2020

Going in, thanks @Flamefire!

@boegel boegel merged commit cec7dd2 into easybuilders:develop Jan 14, 2020
@Flamefire Flamefire deleted the 20200109091351_new_pr_ant1100 branch January 14, 2020 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel approved these changes

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
4.1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@Flamefire @smoors @boegel