Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[22545] Add test for security initialization error #5550

Merged
merged 4 commits into from
Jan 13, 2025
Merged

[22545] Add test for security initialization error #5550

merged 4 commits into from
Jan 13, 2025

Conversation

EugenioCollado
Copy link
Contributor

@EugenioCollado EugenioCollado commented Jan 8, 2025 •
edited
Loading

Description

This PR is a follow up of #5530 updating the macro log and adding regression tests.

After merging, manual backport the commits to the corresponding already created backport branches:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • NA Any new/modified methods have been properly documented using Doxygen.
  • NA Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • NA New feature has been added to the versions.md file (if applicable).
  • NA New feature has been documented/Current behavior is correctly described in the documentation.
  • NA Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@EugenioCollado
Regression tests
b9251e5 
Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>
@EugenioCollado
Update log macro
9a87525 
Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>
@EugenioCollado EugenioCollado added this to the v3.2.0 milestone Jan 8, 2025
@github-actions github-actions bot added the ci-pending PR which CI is running label Jan 8, 2025
@EugenioCollado
Uncrustify
f5401d5 
Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>
@EugenioCollado EugenioCollado requested review from richiprosima and removed request for richiprosima January 8, 2025 14:46
@EugenioCollado EugenioCollado added ci-pending PR which CI is running and removed ci-pending PR which CI is running labels Jan 8, 2025
@EugenioCollado
Fix CI log flush
55fc627 
Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>
@EugenioCollado EugenioCollado requested review from richiprosima and removed request for richiprosima January 9, 2025 08:31
This was referenced Jan 9, 2025
Open
Open
Merged
Open
Mario-DL
Mario-DL approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@EugenioCollado EugenioCollado merged commit 25b117f into master Jan 13, 2025
17 checks passed
@EugenioCollado EugenioCollado deleted the test/pr-5530 branch January 13, 2025 06:30
EugenioCollado added a commit that referenced this pull request Jan 13, 2025
@EugenioCollado
Add test for security initialization error (#5550)
0d51e34 
* Regression tests

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

* Update log macro

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

* Uncrustify

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

* Fix CI log flush

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

---------

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>
EugenioCollado added a commit that referenced this pull request Jan 13, 2025
@EugenioCollado
Add test for security initialization error (#5550)
e0ad456 
* Regression tests

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

* Update log macro

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

* Uncrustify

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

* Fix CI log flush

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

---------

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>
EugenioCollado added a commit that referenced this pull request Jan 13, 2025
@EugenioCollado
Add test for security initialization error (#5550)
1a92af2 
* Regression tests

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

* Update log macro

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

* Uncrustify

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

* Fix CI log flush

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

---------

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>
EugenioCollado added a commit that referenced this pull request Jan 13, 2025
@EugenioCollado
Add test for security initialization error (#5550)
c1e7781 
* Regression tests

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

* Update log macro

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

* Uncrustify

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

* Fix CI log flush

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

---------

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>
EugenioCollado added a commit that referenced this pull request Jan 14, 2025
@mergify @Santti4go @EugenioCollado
Log any errors before cancel_init() (backport #5530) (#5546)
dbfd1f3 
* Log any errors before cancel_init() (#5530)

* Log any errors before cancel_init()

Signed-off-by: Santti4go <santiaupi@gmail.com>

* Code style

Signed-off-by: Santti4go <santiaupi@gmail.com>

* Apply suggestion

Signed-off-by: Santti4go <santiaupi@gmail.com>

---------

Signed-off-by: Santti4go <santiaupi@gmail.com>
(cherry picked from commit 165d64e)

* Add test for security initialization error (#5550)

* Regression tests

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

* Update log macro

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

* Uncrustify

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

* Fix CI log flush

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

---------

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>

---------

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>
Co-authored-by: Santiago <95138114+Santti4go@users.noreply.github.com>
Co-authored-by: EugenioCollado <121509066+EugenioCollado@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mario-DL Mario-DL Mario-DL approved these changes

@richiprosima richiprosima Awaiting requested review from richiprosima

Assignees
No one assigned
Labels
ci-pending PR which CI is running
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@EugenioCollado @Mario-DL