Skip to content

Commit

Permalink
fix(eek): fauly linting rule
Browse files Browse the repository at this point in the history
  • Loading branch information
agliga committed Sep 30, 2024
1 parent fa628f8 commit 477a4a0
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 6 deletions.
5 changes: 5 additions & 0 deletions .changeset/cyan-shirts-turn.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@ebay/skin": patch
---

fix: reverted eek linting issue and fixed gh paths
2 changes: 1 addition & 1 deletion dist/eek/eek.css
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@
font-size: 8px;
}
@media not all and (-webkit-min-device-pixel-ratio: 0),
not all and (resolution >= 0.001dpcm) {
not all and (min-resolution: 0.001dpcm) {
@supports (-webkit-appearance: none) {
.eek__rating {
text-shadow: none;
Expand Down
4 changes: 2 additions & 2 deletions gh.browser.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"dependencies": [
"less-import: ./dist/mixins/public/utility-mixins.less",
"less-import: ./dist/mixins/public/typography-mixins.less",
"less-import: ./dist/mixins/utility-mixins.less",
"less-import: ./dist/mixins/typography-mixins.less",
"less-import: ./dist/gh/gh-mixins.less"
]
}
5 changes: 2 additions & 3 deletions src/sass/eek/eek.scss
Original file line number Diff line number Diff line change
Expand Up @@ -143,9 +143,8 @@ $eek-border-color: $eek-color;
In Safari the EEK icon is not aligned properly as well as the text is broken
Changed a bit of styles there only in order to make it work
*/
/* stylelint-disable-next-line media-feature-name-no-vendor-prefix */
@media not all and (-webkit-min-device-pixel-ratio: 0),
not all and (resolution >= 0.001dpcm) {
/* stylelint-disable-next-line media-feature-name-no-vendor-prefix,media-feature-range-notation */
@media not all and (min-resolution: 0.001dpcm) {
@supports (-webkit-appearance: none) {
.eek__rating {
text-shadow: none;
Expand Down

0 comments on commit 477a4a0

Please sign in to comment.