Skip to content

Commit

Permalink
fix(dropdowns): added fixed support for floating-ui strategy
Browse files Browse the repository at this point in the history
  • Loading branch information
agliga committed Feb 26, 2025
1 parent 86dd8dc commit 091aa98
Show file tree
Hide file tree
Showing 5 changed files with 19 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .changeset/old-clocks-sell.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@ebay/skin": patch
---

fix(dropdowns): added fixed support for floatingui strategy
3 changes: 3 additions & 0 deletions dist/combobox/combobox.css
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,9 @@ span.combobox {
top: calc(100% + 4px);
width: auto;
}
.combobox__listbox--fixed {
position: fixed;
}

.combobox__listbox--reverse,
[dir="rtl"] .combobox__listbox {
Expand Down
3 changes: 3 additions & 0 deletions dist/listbox-button/listbox-button.css
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,9 @@ div.listbox-button__listbox--set-position {
top: calc(100% + 4px);
width: auto;
}
div.listbox-button__listbox--fixed {
position: fixed;
}
[dir="rtl"] div.listbox-button__listbox {
left: unset;
right: 0;
Expand Down
4 changes: 4 additions & 0 deletions dist/menu-button/menu-button.css
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,10 @@
top: calc(100% + 4px);
width: auto;
}
.fake-menu-button__menu--fixed,
.menu-button__menu--fixed {
position: fixed;
}
[dir="rtl"] .fake-menu-button__menu,
[dir="rtl"] .menu-button__menu {
left: unset;
Expand Down
4 changes: 4 additions & 0 deletions src/sass/mixins/private/_dropdown-mixins.scss
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@
width: auto;
}

&--fixed {
position: fixed;
}

[dir="rtl"] & {
left: unset;
right: 0;
Expand Down

0 comments on commit 091aa98

Please sign in to comment.