skip append dummy logs to log dev #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Besroy
commented
Jan 8, 2025
Besroy
force-pushed
the
skip_dummpy_logs_in_compact
branch
2 times, most recently
from
86fefef to
b78115c
Compare
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #624 +/- ##
==========================================
+ Coverage 56.51% 66.14% +9.63%
==========================================
Files 108 109 +1
Lines 10300 10988 +688
Branches 1402 1507 +105
==========================================
+ Hits 5821 7268 +1447
+ Misses 3894 3005 -889
- Partials 585 715 +130 ☔ View full report in Codecov by Sentry. |
Besroy
force-pushed
the
skip_dummpy_logs_in_compact
branch
from
b78115c to
8f015e3
Compare
Besroy
force-pushed
the
skip_dummpy_logs_in_compact
branch
2 times, most recently
from
19878fd to
b8f76c6
Compare
|
@sanebay pls also take a look |
Besroy
force-pushed
the
skip_dummpy_logs_in_compact
branch
from
b8f76c6 to
d4368df
Compare
xiaoxichen
reviewed
Jan 15, 2025
Besroy
force-pushed
the
skip_dummpy_logs_in_compact
branch
from
d4368df to
dc053d7
Compare
1. directly update indices when there are holes in baseline resync 2. update definition of logdev_key::out_of_bound_ld_key and use it to imply log dev can truncate freely. 3. remove is_active check in HomeLogStore::flush to unblock flush when there are holes in m_records
Besroy
force-pushed
the
skip_dummpy_logs_in_compact
branch
from
dc053d7 to
c6275a4
Compare
xiaoxichen
approved these changes
Jan 15, 2025
JacksonYao287
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the baseline resynchronization process, when a follower successfully receives a snapshot, it calls the compact function to truncate all logs that are no larger than snapshot.last_log_idx. In the current implementation, compact initially appends dummy logs up to snapshot.last_log_idx before truncating them. This operation is resource-intensive, and the size of the data waiting to be flushed can exceed the journal vdev's chunk size, posing a risk of system crashes.
This change eliminates the need to append dummy logs to the log device by directly updating certain indices. It also removes the dependency of log dev truncation on log store's LSN.