Remove log store truncation from resource mg #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #620 +/- ##
==========================================
+ Coverage 56.51% 66.08% +9.56%
==========================================
Files 108 109 +1
Lines 10300 10982 +682
Branches 1402 1509 +107
==========================================
+ Hits 5821 7257 +1436
+ Misses 3894 3004 -890
- Partials 585 721 +136 ☔ View full report in Codecov by Sentry. |
Besroy
force-pushed
the
fix_truncation
branch
4 times, most recently
from
ae7436a to
348fa3a
Compare
yuwmao
reviewed
Dec 25, 2024
Besroy
force-pushed
the
fix_truncation
branch
5 times, most recently
from
e6b2adb to
5bddd0d
Compare
xiaoxichen
changed the title
Currently both resource_mgr and raft can call log store's truncate, but resource_mgr will not truncate logs whose lsn less than compact lsn. That means resource_mgr just re-truncate logs which will be / has been truncated in compact. But if resource_mgr and raft call truncate concurrently, crash will happen. So this commit remove it.
xiaoxichen
approved these changes
Jan 2, 2025
Besroy
commented
Jan 2, 2025
| lsn, prev_lsn); | ||
| RD_DBG_ASSERT(m_commit_upto_lsn.compare_exchange_strong(prev_lsn, lsn), | ||
| "Raft Channel: unexpected log {} commited before config {} committed", prev_lsn, lsn); | ||
| if (prev_lsn >= lsn || !m_commit_upto_lsn.compare_exchange_strong(prev_lsn, lsn)) { |
There was a problem hiding this comment.
Thanks @JacksonYao287 , I remove debug assert and use error log here to enhance code readability. PTAL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently both resource_mgr and raft can call log store's
truncate, but resource_mgr will not truncate logs whose lsn less than compact lsn. That means resource_mgr just re-truncate logs which will be / has been truncated incompact. But if resource_mgr and raft call truncate concurrently, crash will happen.For example, raft truncate logs upto compact_lsn and execute
Then resource_mgr truncate truncate_lsn (which is no large than compact_lsn) and execute
m_trunc_ld_key = m_records.at(upto_lsn).m_trunc_key;Since truncate_lsn has been truncated, an exception thrown.This pr remove truncation from resource_mgr to avoid concurrency.