Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reset rreq time every time we reuse a rreq #618

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

Besroy
Copy link
Contributor

@Besroy Besroy commented Dec 23, 2024

The applier_create_req function will insert rreq to m_repl_key_req_map at the first time, then it try to allocate local blks, and if failed to allocate blks, the rreq will not be removed until gc. And if we retry to create req again, the rreq will be reused without update for the timer, which may hit the following issue:

T1: failed to alloc blk for data while receiving it from data channel
T2: recevied log from raft channel and reuse rreq
T3: gc, the corresponding rreq is removed (raft channel is lower than data channel since there are lots of create/seal shard req)
T4: append process cannot find rreq at localize_journal_entry_finish and try to prepare rreq again, so the rreq is new but the entry is old, leading mismatch.

So we reset timer for rreq every time we reuse it.

@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.98%. Comparing base (1a0cef8) to head (52e5323).
Report is 113 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #618      +/-   ##
==========================================
+ Coverage   56.51%   65.98%   +9.46%     
==========================================
  Files         108      109       +1     
  Lines       10300    10985     +685     
  Branches     1402     1509     +107     
==========================================
+ Hits         5821     7248    +1427     
+ Misses       3894     3012     -882     
- Partials      585      725     +140     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

xiaoxichen
xiaoxichen previously approved these changes Dec 24, 2024
@Besroy Besroy merged commit b4ddbaa into eBay:master Dec 24, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants