rename lpc/lsp functions with codec2 prefix to prevent name clash with libspeex #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The change itself looks reasonable. I kicked off the GH action to make sure build and tests work. Interestingly, /~https://github.com/drowe67/freedv-gui also uses Speex. I wonder why this hasn't come up until now. I'll look into what that repo does and report back if I find anything. EDIT: oh, it uses https://gitlab.xiph.org/xiph/speexdsp, not the whole libspeex. That probably explains why it hasn't come up before. |
|
I guess all checks passed? I also couldn't spot any problems with my ffmpeg build. |
Indeed. It's up to @drowe67 whether this merges, though, so I'll wait until he has a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #59
With this change a static build of ffmpeg on alpine linux with both libspeex and libcodec2 enabled succeeds.