make rule configuration default to false to keep BC

driftingly · Oct 26, 2024 · 6d37120 · 6d37120
1 parent 4187297
commit 6d37120
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/Rector/ClassMethod/AddGenericReturnTypeToRelationsRector.php b/src/Rector/ClassMethod/AddGenericReturnTypeToRelationsRector.php
@@ -237,6 +237,12 @@ public function refactorWithScope(Node $node, Scope $scope): ?Node
      */
     public function configure(array $configuration): void
     {
+        if ($configuration === []) {
+            $this->shouldUseNewGenerics = false;
+
+            return;
+        }
+
         Assert::count($configuration, 1);
         Assert::keyExists($configuration, 'shouldUseNewGenerics');
         Assert::boolean($configuration['shouldUseNewGenerics']);

diff --git a/...sMethod/AddGenericReturnTypeToRelationsRector/config/use_old_generics_configured_rule.php b/...sMethod/AddGenericReturnTypeToRelationsRector/config/use_old_generics_configured_rule.php
@@ -8,7 +8,5 @@
 return static function (RectorConfig $rectorConfig): void {
     $rectorConfig->import(__DIR__ . '/../../../../../config/config.php');
 
-    $rectorConfig->ruleWithConfiguration(AddGenericReturnTypeToRelationsRector::class, [
-        'shouldUseNewGenerics' => false,
-    ]);
+    $rectorConfig->ruleWithConfiguration(AddGenericReturnTypeToRelationsRector::class, []);
 };