Skip setting an exception as a default value in ApplyDefaultInsteadOf…

…NullCoalesceRector (#294)

* Update ApplyDefaultInsteadOfNullCoalesceRector.php

* Create skip_throw_exceptions.php.inc

* Fix style;

* Fix lint error;

---------

Co-authored-by: Geni Jaho <jahogeni@gmail.com>

src/Rector/Coalesce/ApplyDefaultInsteadOfNullCoalesceRector.php

@@ -8,6 +8,7 @@
 use PhpParser\Node\Expr\FuncCall;
 use PhpParser\Node\Expr\MethodCall;
 use PhpParser\Node\Expr\StaticCall;
+use PhpParser\Node\Expr\Throw_;
 use PHPStan\Type\ObjectType;
 use Rector\Contract\Rector\ConfigurableRectorInterface;
 use RectorLaravel\AbstractRector;
@@ -107,12 +108,14 @@ public function refactor(Node $node): MethodCall|StaticCall|FuncCall|null
                 $this->isObjectType(
                     $objectType,
                     $applyDefaultWith->getObjectType()) &&
-                $this->isName($call->name, $applyDefaultWith->getMethodName())
+                $this->isName($call->name, $applyDefaultWith->getMethodName()) &&
+                ! $node->right instanceof Throw_
             ) {
                 $valid = true;
             } elseif (
                 $applyDefaultWith->getObjectType() === null &&
-                $this->isName($call->name, $applyDefaultWith->getMethodName())
+                $this->isName($call->name, $applyDefaultWith->getMethodName()) &&
+                ! $node->right instanceof Throw_
             ) {
                 $valid = true;
             }

tests/Rector/Coalesce/ApplyDefaultInsteadOfNullCoalesceRector/Fixture/skip_throw_exceptions.php.inc

@@ -0,0 +1,11 @@
+<?php
+
+namespace RectorLaravel\Tests\Rector\Coalesce\ApplyDefaultInsteadOfNullCoalesceRector\Fixture;
+
+config('app.name') ?? throw new \Exception('No Google maps base URL configured.');
+
+(new \Illuminate\Http\Request())->input('value') ?? throw new \Exception('No Google maps base URL configured.');
+
+\Illuminate\Support\Env::get('APP_NAME') ?? throw new \Exception('No Google maps base URL configured.');
+
+?>