Specify the auth hostname in the constructor

Specify the auth hostname in the constructor instead of via a separate method as authentication occurs immediately.
draios · Dec 28, 2016 · f216efe · f216efe
1 parent 83e8612
commit f216efe
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/userspace/libsinsp/mesos_auth.cpp b/userspace/libsinsp/mesos_auth.cpp
@@ -25,9 +25,10 @@ along with sysdig.  If not, see <http://www.gnu.org/licenses/>.
 #include "mesos_auth.h"
 
 mesos_auth::mesos_auth(const uri::credentials_t& dcos_enterprise_credentials,
+		       string auth_hostname,
 		       int token_refresh_interval)
 	: m_dcos_enterprise_credentials(dcos_enterprise_credentials),
-	  m_auth_uri("https://localhost/acs/api/v1/auth/login"),
+	  m_auth_uri(string("https://") + auth_hostname + string("/acs/api/v1/auth/login")),
 	  m_token_refresh_interval(token_refresh_interval),
 	  m_last_token_refresh_s(0)
 
@@ -42,11 +43,6 @@ mesos_auth::~mesos_auth()
 {
 }
 
-void mesos_auth::set_auth_hostname(string &hostname)
-{
-	m_auth_uri.set_host(hostname);
-}
-
 string mesos_auth::get_token()
 {
 	refresh_token();

diff --git a/userspace/libsinsp/mesos_auth.h b/userspace/libsinsp/mesos_auth.h
@@ -32,11 +32,10 @@ class mesos_auth
 {
 public:
 	mesos_auth(const uri::credentials_t& dcos_enterprise_credentials = uri::credentials_t(),
+		   string auth_hostname = "localhost",
 		   int token_refresh_interval = DCOS_ENTERPRISE_TOKEN_REFRESH_S);
 	virtual ~mesos_auth();
 
-	void set_auth_hostname(string &hostname);
-
 	virtual void refresh_token();
 
 	// Return the current token. The token may expire at any time