Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement delete peer and task in persistent cache #3623

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Oct 30, 2024

Description

This pull request includes several changes to improve the handling and management of persistent cache tasks and peers in the project. The most significant changes involve the addition of new methods for managing persistent peers, the removal of the ReplicaCount field from tasks, and updates to various functions to handle the new structure.

Improvements to Persistent Cache Management:

Task Structure and Management:

Service Updates:

Dependency Update:

  • go.mod: Updated the d7y.io/api/v2 dependency version from v2.0.168 to v2.0.169.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added the enhancement New feature or request label Oct 30, 2024
@gaius-qi gaius-qi added this to the v2.2.0 milestone Oct 30, 2024
@gaius-qi gaius-qi self-assigned this Oct 30, 2024
@gaius-qi gaius-qi requested a review from a team as a code owner October 30, 2024 13:40
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 111 lines in your changes missing coverage. Please review.

Project coverage is 35.48%. Comparing base (4f8fb8f) to head (51a5c64).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
scheduler/service/service_v2.go 0.00% 87 Missing ⚠️
scheduler/resource/persistentcache/peer_manager.go 0.00% 18 Missing ⚠️
scheduler/resource/persistentcache/task_manager.go 0.00% 4 Missing ⚠️
pkg/redis/redis.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3623      +/-   ##
==========================================
+ Coverage   35.47%   35.48%   +0.01%     
==========================================
  Files         335      335              
  Lines       37509    37572      +63     
==========================================
+ Hits        13305    13334      +29     
- Misses      23361    23399      +38     
+ Partials      843      839       -4     
Flag Coverage Δ
unittests 35.48% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
scheduler/resource/persistentcache/task.go 0.00% <ø> (ø)
pkg/redis/redis.go 39.28% <0.00%> (-1.46%) ⬇️
scheduler/resource/persistentcache/task_manager.go 0.00% <0.00%> (ø)
scheduler/resource/persistentcache/peer_manager.go 0.00% <0.00%> (ø)
scheduler/service/service_v2.go 64.36% <0.00%> (-2.30%) ⬇️

... and 4 files with indirect coverage changes

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaius-qi gaius-qi merged commit e826d72 into main Oct 31, 2024
27 checks passed
@gaius-qi gaius-qi deleted the feature/delete-persistent-cache-task branch October 31, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants