Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to clarify the first tuesday branding date #47201

Merged
merged 2 commits into from
Mar 3, 2025

Conversation

marcpopMSFT
Copy link
Member

The text previously said the first of the month as that was an estimate at the time. Since then, it's been pretty consistent that we do branding the week before release so the first Tuesday of the month specifically.

@Copilot Copilot bot review requested due to automatic review settings February 28, 2025 21:28
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Feb 28, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

The PR updates the branding dates in the documentation to reflect that branding now occurs on the first Tuesday rather than the first day of the month.

  • Update branding PR merge dates to "first Tuesday" for servicing releases.
  • Update the servicing schedule table to reflect the change.

Reviewed Changes

File Description
documentation/project-docs/SDK-PR-guide.md Updated merchandising dates and added reference to automation.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Member

@nagilson nagilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for clarifying this document, it's helpful.

One question I still have after reading this is if we have to wait for the tactics schedule update. For example, right now the only code complete dates we've settled on are Feb 10. We dont have a code complete day for March yet, only that GA is March 11, so I'm still not sure if this applies in a situation like this for branches such as 9.0.2xx?

cc @edvilme

@marcpopMSFT
Copy link
Member Author

One question I still have after reading this is if we have to wait for the tactics schedule update. For example, right now the only code complete dates we've settled on are Feb 10. We dont have a code complete day for March yet, only that GA is March 11, so I'm still not sure if this applies in a situation like this for branches such as 9.0.2xx?

@nagilson In the document, I list the third Tuesday of the month as the cutoff. That's not the exact date but the best guess that I have (usually we're taking changes after that but for March for example, we were done a few days earlier). Technically, the official schedule has us code complete on the second Tuesday but it usually takes many days for all the code to flow and I leave the branch open during that (as otherwise, the one week window is really short for getting in a month of codeflow).

@marcpopMSFT marcpopMSFT merged commit 4fc0080 into main Mar 3, 2025
8 checks passed
@marcpopMSFT marcpopMSFT deleted the marcpopMSFT-brandingdate branch March 3, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants